[ConfigSwift] Fix client_app / cocoapods CI from #11769
#11766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
force-pushed
the
nc/broaden-ci-trigger
branch
from
dd71782 to
4699038
Compare
ncooke3
commented
Sep 1, 2023
| @@ -3,6 +3,7 @@ name: client_app | |||
| on: | |||
| pull_request: | |||
| paths: | |||
| - "Firebase*" | |||
ncooke3
changed the title
client_app / cocoapods CI from #11769
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11769, the recent changes to merge the ConfigSwift SDK into the Config SDK were reverted while the API proposal awaits approval. One pair of PRs I didn't revert were #11734 & #11741, which set up a CocoaPods version of the previously existing
spm / client_appworkflow. In the revert PR (#11769), theclient_app / cocoapodsfailed. I merged the PR thinking it could have been a tagging issue, but the workflow is still failing onmaster. I was able to reproduce the error locally but am unsure what's going on. So, I checked out last release's tag, and cherry-picked in the changes to add the CocoaPods test app. I was able to get the same failure. So despite the failure involving RCSwift, it doesn't seem to be related to all the changes/reverts I've made with regard to RCSwift. AddingFirebaseCorein the RCSwift podspec fixes this. Like I said, I was only able to reproduce in the app used by the workflow, and since RCSwift will be changed in a way where this error won't happen in M138, I'm proposing this change to fix CI ahead of M137.Seems to be related to this file importing FirebaseCore but the podspec not depending on FirebaseCore: https://github.com/firebase/firebase-ios-sdk/blob/10.14.0/FirebaseRemoteConfigSwift/Sources/PropertyWrapper/RemoteConfigValueObservable.swift#L18
#no-changelog